Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/fluid pump refactor #4236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Chore/fluid pump refactor #4236

wants to merge 3 commits into from

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Sep 8, 2024

Description

Decrease cognitive complexity of fluid pump methods

Proposed changes

Early return + method that handles fluid removal

Related Issues (if applicable)

FluidPump#tick

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner September 8, 2024 14:44
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Sep 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5d52ee9

https://preview-builds.walshy.dev/download/Slimefun/4236/5d52ee93

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🧹 Chores Refactoring / Cleanup. ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Intybyte @TheBusyBot